Skip to content

Commit

Permalink
hw/intc/arm_gicv3_common: Combine duplicate .subsections in vmstate_g…
Browse files Browse the repository at this point in the history
…icv3_cpu

Commit 6692aac accidentally introduced a second initialization
of the .subsections field of vmstate_gicv3_cpu, instead of adding
the new subsection to the existing list. The effect of this was
probably that migration of GICv3 with virtualization enabled was
broken (or alternatively that migration of ICC_SRE_EL1 was broken,
depending on which of the two initializers the compiler used).
Combine the two into a single list.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20180806123445.1459-3-peter.maydell@linaro.org
  • Loading branch information
pm215 committed Aug 6, 2018
1 parent 78e9ddd commit adc4fda
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions hw/intc/arm_gicv3_common.c
Expand Up @@ -134,9 +134,6 @@ static const VMStateDescription vmstate_gicv3_cpu = {
},
.subsections = (const VMStateDescription * []) {
&vmstate_gicv3_cpu_virt,
NULL
},
.subsections = (const VMStateDescription * []) {
&vmstate_gicv3_cpu_sre_el1,
NULL
}
Expand Down

0 comments on commit adc4fda

Please sign in to comment.