Skip to content

Commit

Permalink
include/disas/dis-asm.h: Handle being included outside 'extern "C"'
Browse files Browse the repository at this point in the history
Make dis-asm.h handle being included outside an 'extern "C"' block;
this allows us to remove the 'extern "C"' blocks that our two C++
files that include it are using.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
  • Loading branch information
pm215 committed May 10, 2021
1 parent a5593cd commit ae45ea1
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 6 deletions.
2 changes: 0 additions & 2 deletions disas/arm-a64.cc
Expand Up @@ -18,9 +18,7 @@
*/

#include "qemu/osdep.h"
extern "C" {
#include "disas/dis-asm.h"
}

#include "vixl/a64/disasm-a64.h"

Expand Down
2 changes: 0 additions & 2 deletions disas/nanomips.cpp
Expand Up @@ -28,9 +28,7 @@
*/

#include "qemu/osdep.h"
extern "C" {
#include "disas/dis-asm.h"
}

#include <cstring>
#include <stdexcept>
Expand Down
12 changes: 10 additions & 2 deletions include/disas/dis-asm.h
Expand Up @@ -9,6 +9,12 @@
#ifndef DISAS_DIS_ASM_H
#define DISAS_DIS_ASM_H

#include "qemu/bswap.h"

#ifdef __cplusplus
extern "C" {
#endif

typedef void *PTR;
typedef uint64_t bfd_vma;
typedef int64_t bfd_signed_vma;
Expand Down Expand Up @@ -479,8 +485,6 @@ bool cap_disas_plugin(disassemble_info *info, uint64_t pc, size_t size);

/* from libbfd */

#include "qemu/bswap.h"

static inline bfd_vma bfd_getl64(const bfd_byte *addr)
{
return ldq_le_p(addr);
Expand Down Expand Up @@ -508,4 +512,8 @@ static inline bfd_vma bfd_getb16(const bfd_byte *addr)

typedef bool bfd_boolean;

#ifdef __cplusplus
}
#endif

#endif /* DISAS_DIS_ASM_H */

0 comments on commit ae45ea1

Please sign in to comment.