Skip to content

Commit

Permalink
hw/mips/fuloong2e: use pci_init_nic_devices()
Browse files Browse the repository at this point in the history
The previous behaviour was: *if* the first NIC specified on the command
line was an RTL8139 (or unspecified model) then it gets assigned to PCI
slot 7, which is where the Fuloong board had an RTL8139. All other
devices (including the first, if it was specified as anything other than
an rtl8319) get dynamically assigned on the bus.

The new behaviour is subtly different: If the first NIC was given a
specific model *other* than rtl8139, and a subsequent NIC was not,
then the rtl8139 (or unspecified) NIC will go to slot 7 and the rest
will be dynamically assigned.

Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Reviewed-by: Thomas Huth <thuth@redhat.com>
  • Loading branch information
dwmw2 committed Feb 1, 2024
1 parent 8014f2b commit aff3ec4
Showing 1 changed file with 3 additions and 13 deletions.
16 changes: 3 additions & 13 deletions hw/mips/fuloong2e.c
Original file line number Diff line number Diff line change
Expand Up @@ -201,19 +201,9 @@ static void main_cpu_reset(void *opaque)
/* Network support */
static void network_init(PCIBus *pci_bus)
{
int i;

for (i = 0; i < nb_nics; i++) {
NICInfo *nd = &nd_table[i];
const char *default_devaddr = NULL;

if (i == 0 && (!nd->model || strcmp(nd->model, "rtl8139") == 0)) {
/* The Fuloong board has a RTL8139 card using PCI SLOT 7 */
default_devaddr = "07";
}

pci_nic_init_nofail(nd, pci_bus, "rtl8139", default_devaddr);
}
/* The Fuloong board has a RTL8139 card using PCI SLOT 7 */
pci_init_nic_in_slot(pci_bus, "rtl8139", NULL, "07");
pci_init_nic_devices(pci_bus, "rtl8139");
}

static void mips_fuloong2e_init(MachineState *machine)
Expand Down

0 comments on commit aff3ec4

Please sign in to comment.