Skip to content

Commit

Permalink
hw/rdma: Fix possible usage of a NULL pointer
Browse files Browse the repository at this point in the history
Coverity CID 1390586; The cq handle is provided by the guest
and cannot be trusted to be previuosly allocated.
Fix it by exiting the completion flow.

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
Message-Id: <20180430200223.4119-3-marcel.apfelbaum@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
  • Loading branch information
marcel-apf committed May 3, 2018
1 parent 1bad495 commit b0197cf
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions hw/rdma/vmw/pvrdma_qp_ops.c
Expand Up @@ -216,6 +216,7 @@ void pvrdma_cq_poll(RdmaDeviceResources *dev_res, uint32_t cq_handle)
cq = rdma_rm_get_cq(dev_res, cq_handle);
if (!cq) {
pr_dbg("Invalid CQ# %d\n", cq_handle);
return;
}

rdma_backend_poll_cq(dev_res, &cq->backend_cq);
Expand Down

0 comments on commit b0197cf

Please sign in to comment.