Skip to content

Commit

Permalink
hw/ide/ahci: Remove SysbusAHCIState::num_ports field
Browse files Browse the repository at this point in the history
No need to duplicate AHCIState::ports, directly access it.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20240213081201.78951-9-philmd@linaro.org>
  • Loading branch information
philmd committed Feb 15, 2024
1 parent be02150 commit b0bccc6
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
3 changes: 1 addition & 2 deletions hw/ide/ahci.c
Original file line number Diff line number Diff line change
Expand Up @@ -1862,12 +1862,11 @@ static void sysbus_ahci_realize(DeviceState *dev, Error **errp)
{
SysbusAHCIState *s = SYSBUS_AHCI(dev);

s->ahci.ports = s->num_ports;
ahci_realize(&s->ahci, dev, &address_space_memory);
}

static Property sysbus_ahci_properties[] = {
DEFINE_PROP_UINT32("num-ports", SysbusAHCIState, num_ports, 1),
DEFINE_PROP_UINT32("num-ports", SysbusAHCIState, ahci.ports, 1),
DEFINE_PROP_END_OF_LIST(),
};

Expand Down
1 change: 0 additions & 1 deletion include/hw/ide/ahci.h
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ struct SysbusAHCIState {
/*< public >*/

AHCIState ahci;
uint32_t num_ports;
};

#define TYPE_ALLWINNER_AHCI "allwinner-ahci"
Expand Down

0 comments on commit b0bccc6

Please sign in to comment.