Skip to content

Commit

Permalink
hw/tcx: Remove unused 'addr' field and the property that sets it
Browse files Browse the repository at this point in the history
Remove the 'addr' field from TCXState (since it is completely unused),
also the qdev property which sets it. This seems to be a relic from
many years past; devices don't need to know where they are mapped.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
  • Loading branch information
pm215 authored and stefanhaRH committed Mar 28, 2013
1 parent 0f9d76e commit b0d62a3
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion hw/sparc/sun4m.c
Expand Up @@ -575,7 +575,6 @@ static void tcx_init(hwaddr addr, int vram_size, int width,
SysBusDevice *s;

dev = qdev_create(NULL, "SUNW,tcx");
qdev_prop_set_taddr(dev, "addr", addr);
qdev_prop_set_uint32(dev, "vram_size", vram_size);
qdev_prop_set_uint16(dev, "width", width);
qdev_prop_set_uint16(dev, "height", height);
Expand Down
2 changes: 0 additions & 2 deletions hw/tcx.c
Expand Up @@ -37,7 +37,6 @@

typedef struct TCXState {
SysBusDevice busdev;
hwaddr addr;
QemuConsole *con;
uint8_t *vram;
uint32_t *vram24, *cplane;
Expand Down Expand Up @@ -707,7 +706,6 @@ static void tcx24_screen_dump(void *opaque, const char *filename, bool cswitch,
}

static Property tcx_properties[] = {
DEFINE_PROP_TADDR("addr", TCXState, addr, -1),
DEFINE_PROP_HEX32("vram_size", TCXState, vram_size, -1),
DEFINE_PROP_UINT16("width", TCXState, width, -1),
DEFINE_PROP_UINT16("height", TCXState, height, -1),
Expand Down

0 comments on commit b0d62a3

Please sign in to comment.