Skip to content

Commit

Permalink
isa: remove isa_mem_base variable
Browse files Browse the repository at this point in the history
Now that isa_mem_base variable is always 0, we can remove its usage.

Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
Signed-off-by: Leon Alrae <leon.alrae@imgtec.com>
  • Loading branch information
hpoussin authored and Leon Alrae committed Feb 13, 2015
1 parent f720f20 commit b19c1c0
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 7 deletions.
2 changes: 1 addition & 1 deletion hw/display/cirrus_vga.c
Expand Up @@ -2907,7 +2907,7 @@ static void cirrus_init_common(CirrusVGAState *s, Object *owner,
bank, 1);
}
memory_region_add_subregion_overlap(system_memory,
isa_mem_base + 0x000a0000,
0x000a0000,
&s->low_mem_container,
1);
memory_region_set_coalescing(&s->low_mem);
Expand Down
2 changes: 1 addition & 1 deletion hw/display/vga-isa.c
Expand Up @@ -64,7 +64,7 @@ static void vga_isa_realizefn(DeviceState *dev, Error **errp)
isa_register_portio_list(isadev, 0x1ce, vbe_ports, s, "vbe");
}
memory_region_add_subregion_overlap(isa_address_space(isadev),
isa_mem_base + 0x000a0000,
0x000a0000,
vga_io_memory, 1);
memory_region_set_coalescing(vga_io_memory);
s->con = graphic_console_init(DEVICE(dev), 0, s->hw_ops, s);
Expand Down
3 changes: 1 addition & 2 deletions hw/display/vga.c
Expand Up @@ -177,7 +177,6 @@ static void vga_update_memory_access(VGACommonState *s)
size = 0x8000;
break;
}
base += isa_mem_base;
memory_region_init_alias(&s->chain4_alias, memory_region_owner(&s->vram),
"vga.chain4", &s->vram, offset, size);
memory_region_add_subregion_overlap(s->legacy_address_space, base,
Expand Down Expand Up @@ -2218,7 +2217,7 @@ void vga_init(VGACommonState *s, Object *obj, MemoryRegion *address_space,

vga_io_memory = vga_init_io(s, obj, &vga_ports, &vbe_ports);
memory_region_add_subregion_overlap(address_space,
isa_mem_base + 0x000a0000,
0x000a0000,
vga_io_memory,
1);
memory_region_set_coalescing(vga_io_memory);
Expand Down
1 change: 0 additions & 1 deletion hw/isa/isa-bus.c
Expand Up @@ -23,7 +23,6 @@
#include "hw/isa/isa.h"

static ISABus *isabus;
hwaddr isa_mem_base = 0;

static void isabus_dev_print(Monitor *mon, DeviceState *dev, int indent);
static char *isabus_get_fw_dev_path(DeviceState *dev);
Expand Down
2 changes: 0 additions & 2 deletions include/hw/isa/isa.h
Expand Up @@ -99,8 +99,6 @@ static inline ISABus *isa_bus_from_device(ISADevice *d)
return ISA_BUS(qdev_get_parent_bus(DEVICE(d)));
}

extern hwaddr isa_mem_base;

/* dma.c */
int DMA_get_channel_mode (int nchan);
int DMA_read_memory (int nchan, void *buf, int pos, int size);
Expand Down

0 comments on commit b19c1c0

Please sign in to comment.