Skip to content

Commit

Permalink
tests/test-qga: Demonstrate the guest-agent ignores "id"
Browse files Browse the repository at this point in the history
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20180703085358.13941-9-armbru@redhat.com>
  • Loading branch information
Markus Armbruster committed Jul 3, 2018
1 parent 80cd93b commit b5f8431
Showing 1 changed file with 20 additions and 0 deletions.
20 changes: 20 additions & 0 deletions tests/test-qga.c
Expand Up @@ -227,6 +227,25 @@ static void test_qga_ping(gconstpointer fix)
qobject_unref(ret);
}

static void test_qga_invalid_id(gconstpointer fix)
{
/*
* FIXME "id" is ignored; it should either be repeated in the
* reply, or rejected on input
*/
const TestFixture *fixture = fix;
QDict *ret, *val;

ret = qmp_fd(fixture->fd, "{'execute': 'guest-ping', 'id': 1}");
g_assert_nonnull(ret);
qmp_assert_no_error(ret);

val = qdict_get_qdict(ret, "return");
g_assert(!qdict_haskey(val, "id"));

qobject_unref(ret);
}

static void test_qga_invalid_args(gconstpointer fix)
{
const TestFixture *fixture = fix;
Expand Down Expand Up @@ -934,6 +953,7 @@ int main(int argc, char **argv)
g_test_add_data_func("/qga/file-ops", &fix, test_qga_file_ops);
g_test_add_data_func("/qga/file-write-read", &fix, test_qga_file_write_read);
g_test_add_data_func("/qga/get-time", &fix, test_qga_get_time);
g_test_add_data_func("/qga/invalid-id", &fix, test_qga_invalid_id);
g_test_add_data_func("/qga/invalid-cmd", &fix, test_qga_invalid_cmd);
g_test_add_data_func("/qga/invalid-args", &fix, test_qga_invalid_args);
g_test_add_data_func("/qga/fsfreeze-status", &fix,
Expand Down

0 comments on commit b5f8431

Please sign in to comment.