Skip to content

Commit

Permalink
usb/ohci: Merge ohci_async_cancel_device() into ohci_child_detach()
Browse files Browse the repository at this point in the history
These two do the same and only used once so no need to have two
functions, simplify by merging them.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <5fc8ba0bbf55703014d22dd06ab2f9eabaf370bf.1643117600.git.balaton@eik.bme.hu>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
  • Loading branch information
zbalaton authored and kraxel committed Mar 4, 2022
1 parent 37bf065 commit b6b0c06
Showing 1 changed file with 4 additions and 9 deletions.
13 changes: 4 additions & 9 deletions hw/usb/hcd-ohci.c
Expand Up @@ -1725,8 +1725,10 @@ static void ohci_attach(USBPort *port1)
}
}

static void ohci_async_cancel_device(OHCIState *ohci, USBDevice *dev)
static void ohci_child_detach(USBPort *port1, USBDevice *dev)
{
OHCIState *ohci = port1->opaque;

if (ohci->async_td &&
usb_packet_is_inflight(&ohci->usb_packet) &&
ohci->usb_packet.ep->dev == dev) {
Expand All @@ -1735,20 +1737,13 @@ static void ohci_async_cancel_device(OHCIState *ohci, USBDevice *dev)
}
}

static void ohci_child_detach(USBPort *port1, USBDevice *child)
{
OHCIState *s = port1->opaque;

ohci_async_cancel_device(s, child);
}

static void ohci_detach(USBPort *port1)
{
OHCIState *s = port1->opaque;
OHCIPort *port = &s->rhport[port1->index];
uint32_t old_state = port->ctrl;

ohci_async_cancel_device(s, port1->dev);
ohci_child_detach(port1, port1->dev);

/* set connect status */
if (port->ctrl & OHCI_PORT_CCS) {
Expand Down

0 comments on commit b6b0c06

Please sign in to comment.