Skip to content

Commit

Permalink
target/arm/translate-neon.c: Handle VTBL UNDEF case before VFP access…
Browse files Browse the repository at this point in the history
… check

Checks for UNDEF cases should go before the "is VFP enabled?" access
check, except in special cases. Move a stray UNDEF check in the VTBL
trans function up above the access check.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20201109145324.2859-1-peter.maydell@linaro.org
  • Loading branch information
pm215 committed Nov 10, 2020
1 parent 8006c98 commit b6c56c8
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions target/arm/translate-neon.c.inc
Expand Up @@ -2874,10 +2874,6 @@ static bool trans_VTBL(DisasContext *s, arg_VTBL *a)
return false;
}

if (!vfp_access_check(s)) {
return true;
}

if ((a->vn + a->len + 1) > 32) {
/*
* This is UNPREDICTABLE; we choose to UNDEF to avoid the
Expand All @@ -2886,6 +2882,10 @@ static bool trans_VTBL(DisasContext *s, arg_VTBL *a)
return false;
}

if (!vfp_access_check(s)) {
return true;
}

desc = tcg_const_i32((a->vn << 2) | a->len);
def = tcg_temp_new_i64();
if (a->op) {
Expand Down

0 comments on commit b6c56c8

Please sign in to comment.