Skip to content

Commit

Permalink
Clean up includes
Browse files Browse the repository at this point in the history
Clean up includes so that osdep.h is included first and headers
which it implies are not included manually.

This commit was created with scripts/clean-includes, with the changes
to the following files manually reverted:

    contrib/libvhost-user/libvhost-user-glib.h
    contrib/libvhost-user/libvhost-user.c
    contrib/libvhost-user/libvhost-user.h
    linux-user/mips64/cpu_loop.c
    linux-user/mips64/signal.c
    linux-user/sparc64/cpu_loop.c
    linux-user/sparc64/signal.c
    linux-user/x86_64/cpu_loop.c
    linux-user/x86_64/signal.c
    target/s390x/gen-features.c
    tests/migration/s390x/a-b-bios.c
    tests/test-rcu-simpleq.c
    tests/test-rcu-tailq.c

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20181204172535.2799-1-armbru@redhat.com>
Acked-by: Eduardo Habkost <ehabkost@redhat.com>
Acked-by: Halil Pasic <pasic@linux.ibm.com>
Acked-by: Yuval Shaia <yuval.shaia@oracle.com>
Acked-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
  • Loading branch information
Markus Armbruster committed Dec 20, 2018
1 parent b72566a commit b7d8946
Show file tree
Hide file tree
Showing 18 changed files with 5 additions and 18 deletions.
2 changes: 0 additions & 2 deletions contrib/elf2dmp/pdb.h
Expand Up @@ -8,8 +8,6 @@
#ifndef PDB_H
#define PDB_H

#include <stdint.h>
#include <stdlib.h>

typedef struct GUID {
unsigned int Data1;
Expand Down
1 change: 0 additions & 1 deletion contrib/elf2dmp/pe.h
Expand Up @@ -8,7 +8,6 @@
#ifndef PE_H
#define PE_H

#include <stdint.h>

typedef struct IMAGE_DOS_HEADER {
uint16_t e_magic; /* 0x00: MZ Header signature */
Expand Down
1 change: 0 additions & 1 deletion contrib/elf2dmp/qemu_elf.h
Expand Up @@ -8,7 +8,6 @@
#ifndef QEMU_ELF_H
#define QEMU_ELF_H

#include <stdint.h>
#include <elf.h>

typedef struct QEMUCPUSegment {
Expand Down
1 change: 0 additions & 1 deletion contrib/vhost-user-blk/vhost-user-blk.c
Expand Up @@ -20,7 +20,6 @@
#include "contrib/libvhost-user/libvhost-user-glib.h"
#include "contrib/libvhost-user/libvhost-user.h"

#include <glib.h>

struct virtio_blk_inhdr {
unsigned char status;
Expand Down
1 change: 0 additions & 1 deletion contrib/vhost-user-scsi/vhost-user-scsi.c
Expand Up @@ -16,7 +16,6 @@
#include "contrib/libvhost-user/libvhost-user-glib.h"
#include "standard-headers/linux/virtio_scsi.h"

#include <glib.h>

#define VUS_ISCSI_INITIATOR "iqn.2016-11.com.nutanix:vhost-user-scsi"

Expand Down
1 change: 1 addition & 0 deletions hw/rdma/rdma_utils.c
Expand Up @@ -13,6 +13,7 @@
*
*/

#include "qemu/osdep.h"
#include "rdma_utils.h"

#ifdef PVRDMA_DEBUG
Expand Down
1 change: 0 additions & 1 deletion hw/rdma/rdma_utils.h
Expand Up @@ -17,7 +17,6 @@
#ifndef RDMA_UTILS_H
#define RDMA_UTILS_H

#include "qemu/osdep.h"
#include "hw/pci/pci.h"
#include "sysemu/dma.h"

Expand Down
1 change: 0 additions & 1 deletion hw/rdma/vmw/pvrdma_dev_ring.h
Expand Up @@ -16,7 +16,6 @@
#ifndef PVRDMA_DEV_RING_H
#define PVRDMA_DEV_RING_H

#include "qemu/typedefs.h"

#define MAX_RING_NAME_SZ 32

Expand Down
2 changes: 1 addition & 1 deletion hw/vfio/ap.c
Expand Up @@ -10,9 +10,9 @@
* directory.
*/

#include "qemu/osdep.h"
#include <linux/vfio.h>
#include <sys/ioctl.h>
#include "qemu/osdep.h"
#include "qapi/error.h"
#include "hw/sysbus.h"
#include "hw/vfio/vfio.h"
Expand Down
1 change: 0 additions & 1 deletion include/qemu/vfio-helpers.h
Expand Up @@ -12,7 +12,6 @@

#ifndef QEMU_VFIO_HELPERS_H
#define QEMU_VFIO_HELPERS_H
#include "qemu/typedefs.h"

typedef struct QEMUVFIOState QEMUVFIOState;

Expand Down
1 change: 0 additions & 1 deletion include/sysemu/whpx.h
Expand Up @@ -13,7 +13,6 @@
#ifndef QEMU_WHPX_H
#define QEMU_WHPX_H

#include "config-host.h"
#include "qemu-common.h"

int whpx_init_vcpu(CPUState *cpu);
Expand Down
3 changes: 2 additions & 1 deletion target/i386/sev.c
Expand Up @@ -11,12 +11,13 @@
*
*/

#include "qemu/osdep.h"

#include <linux/kvm.h>
#include <linux/psp-sev.h>

#include <sys/ioctl.h>

#include "qemu/osdep.h"
#include "qapi/error.h"
#include "qom/object_interfaces.h"
#include "qemu/base64.h"
Expand Down
1 change: 0 additions & 1 deletion target/i386/whp-dispatch.h
@@ -1,5 +1,4 @@
#include "windows.h"
#include <stdbool.h>

#include <WinHvPlatform.h>
#include <WinHvEmulation.h>
Expand Down
1 change: 0 additions & 1 deletion target/riscv/fpu_helper.c
Expand Up @@ -17,7 +17,6 @@
*/

#include "qemu/osdep.h"
#include <stdlib.h>
#include "cpu.h"
#include "qemu/host-utils.h"
#include "exec/exec-all.h"
Expand Down
1 change: 0 additions & 1 deletion tests/fp/platform.h
Expand Up @@ -29,7 +29,6 @@
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#include "config-host.h"

#ifndef HOST_WORDS_BIGENDIAN
#define LITTLEENDIAN 1
Expand Down
1 change: 0 additions & 1 deletion tests/tpm-util.h
Expand Up @@ -13,7 +13,6 @@
#ifndef TESTS_TPM_UTIL_H
#define TESTS_TPM_UTIL_H

#include "qemu/osdep.h"
#include "io/channel-socket.h"

typedef void (tx_func)(QTestState *s,
Expand Down
2 changes: 1 addition & 1 deletion tests/vhost-user-bridge.c
Expand Up @@ -29,8 +29,8 @@

#define _FILE_OFFSET_BITS 64

#include "qemu/atomic.h"
#include "qemu/osdep.h"
#include "qemu/atomic.h"
#include "qemu/iov.h"
#include "standard-headers/linux/virtio_net.h"
#include "contrib/libvhost-user/libvhost-user.h"
Expand Down
1 change: 0 additions & 1 deletion util/qemu-thread-common.h
Expand Up @@ -13,7 +13,6 @@
#ifndef QEMU_THREAD_COMMON_H
#define QEMU_THREAD_COMMON_H

#include "qemu/typedefs.h"
#include "qemu/thread.h"
#include "trace.h"

Expand Down

0 comments on commit b7d8946

Please sign in to comment.