Skip to content

Commit

Permalink
slirp: improve windows headers inclusion
Browse files Browse the repository at this point in the history
Our API usage requires Vista, set WIN32_LEAN_AND_MEAN to fix a number
of issues (winsock2.h include order for ex, which is better to include
first for legacy reasons).

While at it, group redundants #ifndef _WIN32 blocks.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
  • Loading branch information
elmarco authored and sthibaul committed Feb 7, 2019
1 parent 35ee75f commit ba1be96
Showing 1 changed file with 11 additions and 11 deletions.
22 changes: 11 additions & 11 deletions slirp/slirp.h
Expand Up @@ -3,10 +3,19 @@

#ifdef _WIN32

/* as defined in sdkddkver.h */
#ifndef _WIN32_WINNT
#define _WIN32_WINNT 0x0600 /* Vista */
#endif
/* reduces the number of implicitly included headers */
#ifndef WIN32_LEAN_AND_MEAN
#define WIN32_LEAN_AND_MEAN
#endif

typedef char *caddr_t;

# include <windows.h>
# include <winsock2.h>
# include <windows.h>
# include <ws2tcpip.h>
# include <sys/timeb.h>
# include <iphlpapi.h>
Expand All @@ -19,19 +28,10 @@ typedef char *caddr_t;

#ifndef _WIN32
#include <sys/uio.h>
#endif

#ifndef _WIN32
#include <netinet/in.h>
#include <arpa/inet.h>
#endif

#ifndef _WIN32
#include <sys/socket.h>
#endif

#ifndef _WIN32
# include <sys/ioctl.h>
#include <sys/ioctl.h>
#endif

#ifdef __APPLE__
Expand Down

0 comments on commit ba1be96

Please sign in to comment.