Skip to content

Commit

Permalink
qtest: Don't reset on qtest chardev connect
Browse files Browse the repository at this point in the history
libqtest's qtest_init() connecting to the qtest socket triggers reset.
This was coded in the hope we could use the same QEMU process for
multiple tests that way.  Never used.  Injects an extra reset even
when it's not used, and that can mess up tests such as the one of
-boot once I'm about to add.  Drop it.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-id: 1372254743-15808-2-git-send-email-armbru@redhat.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
  • Loading branch information
Markus Armbruster authored and Anthony Liguori committed Jul 18, 2013
1 parent 1d9358e commit ba646ff
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion qtest.c
Expand Up @@ -472,7 +472,12 @@ static void qtest_event(void *opaque, int event)

switch (event) {
case CHR_EVENT_OPENED:
qemu_system_reset(false);
/*
* We used to call qemu_system_reset() here, hoping we could
* use the same process for multiple tests that way. Never
* used. Injects an extra reset even when it's not used, and
* that can mess up tests, e.g. -boot once.
*/
for (i = 0; i < ARRAY_SIZE(irq_levels); i++) {
irq_levels[i] = 0;
}
Expand Down

0 comments on commit ba646ff

Please sign in to comment.