Skip to content

Commit

Permalink
tests/unit/test-char: Fix qemu_socket(), make_udp_socket() check
Browse files Browse the repository at this point in the history
qemu_socket() and make_udp_socket() return a file descriptor on
success, -1 on failure.  The check misinterprets 0 as failure.  Fix
that.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20240203080228.2766159-3-armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
  • Loading branch information
Markus Armbruster committed Feb 12, 2024
1 parent 785d155 commit ba96b55
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/unit/test-char.c
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,7 @@ static int make_udp_socket(int *port)
socklen_t alen = sizeof(addr);
int ret, sock = qemu_socket(PF_INET, SOCK_DGRAM, 0);

g_assert_cmpint(sock, >, 0);
g_assert_cmpint(sock, >=, 0);
addr.sin_family = AF_INET ;
addr.sin_addr.s_addr = htonl(INADDR_ANY);
addr.sin_port = 0;
Expand Down Expand Up @@ -1401,7 +1401,7 @@ static void char_hotswap_test(void)

int port;
int sock = make_udp_socket(&port);
g_assert_cmpint(sock, >, 0);
g_assert_cmpint(sock, >=, 0);

chr_args = g_strdup_printf("udp:127.0.0.1:%d", port);

Expand Down

0 comments on commit ba96b55

Please sign in to comment.