Skip to content

Commit

Permalink
migration: Refactor auto-converge capability logic
Browse files Browse the repository at this point in the history
Check if block migration is running before throttling
guest down in auto-converge way.

Note that this modification is kind of like code clean,
because block migration does not depend on auto-converge
capability, so the order of checks can be adjusted.

Signed-off-by: Hyman Huang(黄勇) <yong.huang@smartx.com>
Acked-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Message-Id: <168618975839.6361.17407633874747688653-5@git.sr.ht>
Signed-off-by: Juan Quintela <quintela@redhat.com>
  • Loading branch information
HuangSuiXiao authored and Juan Quintela committed Jul 26, 2023
1 parent dc62395 commit bb9993c
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion migration/ram.c
Original file line number Diff line number Diff line change
Expand Up @@ -995,7 +995,11 @@ static void migration_trigger_throttle(RAMState *rs)
/* During block migration the auto-converge logic incorrectly detects
* that ram migration makes no progress. Avoid this by disabling the
* throttling logic during the bulk phase of block migration. */
if (migrate_auto_converge() && !blk_mig_bulk_active()) {
if (blk_mig_bulk_active()) {
return;
}

if (migrate_auto_converge()) {
/* The following detection logic can be refined later. For now:
Check to see if the ratio between dirtied bytes and the approx.
amount of bytes that just got transferred since the last time
Expand Down

0 comments on commit bb9993c

Please sign in to comment.