Skip to content

Commit

Permalink
x86: fix pcmpestrm and pcmpistrm
Browse files Browse the repository at this point in the history
Fix obvious typos (decrement and off-by-one error) in pcmpestrm and pcmpistrm
which resulted in infinite loop. Reported by Frank Mehnert,
spotted also by Coverity (bug 84752853).

Reported-by: Frank Mehnert <frank.mehnert@oracle.com>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
  • Loading branch information
blueswirl committed Nov 19, 2011
1 parent 725e14e commit bc42689
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions target-i386/ops_sse.h
Expand Up @@ -1996,11 +1996,13 @@ void glue(helper_pcmpestrm, SUFFIX) (Reg *d, Reg *s, uint32_t ctrl)

if ((ctrl >> 6) & 1) {
if (ctrl & 1)
for (i = 0; i <= 8; i--, res >>= 1)
for (i = 0; i < 8; i++, res >>= 1) {
d->W(i) = (res & 1) ? ~0 : 0;
}
else
for (i = 0; i <= 16; i--, res >>= 1)
for (i = 0; i < 16; i++, res >>= 1) {
d->B(i) = (res & 1) ? ~0 : 0;
}
} else {
d->Q(1) = 0;
d->Q(0) = res;
Expand Down Expand Up @@ -2028,11 +2030,13 @@ void glue(helper_pcmpistrm, SUFFIX) (Reg *d, Reg *s, uint32_t ctrl)

if ((ctrl >> 6) & 1) {
if (ctrl & 1)
for (i = 0; i <= 8; i--, res >>= 1)
for (i = 0; i < 8; i++, res >>= 1) {
d->W(i) = (res & 1) ? ~0 : 0;
}
else
for (i = 0; i <= 16; i--, res >>= 1)
for (i = 0; i < 16; i++, res >>= 1) {
d->B(i) = (res & 1) ? ~0 : 0;
}
} else {
d->Q(1) = 0;
d->Q(0) = res;
Expand Down

0 comments on commit bc42689

Please sign in to comment.