Skip to content

Commit

Permalink
s390x/pci: code cleanup
Browse files Browse the repository at this point in the history
Now that each S390 PCI device uses an IO region as MSIX region. The
code in s390_translate_iommu() will never be triggered. Let's remove
it.

Signed-off-by: Yi Min Zhao <zyimin@linux.vnet.ibm.com>
Reviewed-by: Pierre Morel <pmorel@linux.vnet.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
  • Loading branch information
Yi Min Zhao authored and borntraeger committed Sep 28, 2016
1 parent 8f95595 commit bfcec59
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions hw/s390x/s390-pci-bus.c
Original file line number Diff line number Diff line change
Expand Up @@ -404,17 +404,6 @@ static IOMMUTLBEntry s390_translate_iommu(MemoryRegion *iommu, hwaddr addr,

DPRINTF("iommu trans addr 0x%" PRIx64 "\n", addr);

/* s390 does not have an APIC mapped to main storage so we use
* a separate AddressSpace only for msix notifications
*/
if (addr == ZPCI_MSI_ADDR) {
ret.iova = addr;
ret.translated_addr = addr;
ret.addr_mask = 0xfff;
ret.perm = IOMMU_RW;
return ret;
}

if (addr < pbdev->pba || addr > pbdev->pal) {
return ret;
}
Expand Down

0 comments on commit bfcec59

Please sign in to comment.