Skip to content

Commit

Permalink
usb: async control xfer fixup
Browse files Browse the repository at this point in the history
Need to clear p->result after copying setup data using usb_packet_copy()
because we'll reuse the USBPacket for the data transfer.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
  • Loading branch information
kraxel committed Aug 16, 2012
1 parent 2b97f88 commit c19537a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions hw/usb/core.c
Expand Up @@ -107,6 +107,7 @@ static int do_token_setup(USBDevice *s, USBPacket *p)
}

usb_packet_copy(p, s->setup_buf, p->iov.size);
p->result = 0;
s->setup_len = (s->setup_buf[7] << 8) | s->setup_buf[6];
s->setup_index = 0;

Expand Down
1 change: 1 addition & 0 deletions hw/usb/host-linux.c
Expand Up @@ -1045,6 +1045,7 @@ static int usb_host_handle_control(USBDevice *dev, USBPacket *p,

/* Note request is (bRequestType << 8) | bRequest */
trace_usb_host_req_control(s->bus_num, s->addr, p, request, value, index);
assert(p->result == 0);

switch (request) {
case DeviceOutRequest | USB_REQ_SET_ADDRESS:
Expand Down

0 comments on commit c19537a

Please sign in to comment.