Skip to content

Commit

Permalink
net: etraxfs_eth: convert SysBus init method to a realize method
Browse files Browse the repository at this point in the history
Cc: Edgar E. Iglesias <edgar.iglesias@gmail.com>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20181001063803.22330-2-clg@kaod.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
  • Loading branch information
legoater authored and ehabkost committed Oct 24, 2018
1 parent 005fecc commit c24828b
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions hw/net/etraxfs_eth.c
Expand Up @@ -23,6 +23,7 @@
*/

#include "qemu/osdep.h"
#include "qapi/error.h"
#include "hw/sysbus.h"
#include "net/net.h"
#include "hw/cris/etraxfs.h"
Expand Down Expand Up @@ -584,14 +585,14 @@ static NetClientInfo net_etraxfs_info = {
.link_status_changed = eth_set_link,
};

static int fs_eth_init(SysBusDevice *sbd)
static void etraxfs_eth_realize(DeviceState *dev, Error **errp)
{
DeviceState *dev = DEVICE(sbd);
SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
ETRAXFSEthState *s = ETRAX_FS_ETH(dev);

if (!s->dma_out || !s->dma_in) {
error_report("Unconnected ETRAX-FS Ethernet MAC");
return -1;
error_setg(errp, "Unconnected ETRAX-FS Ethernet MAC");
return;
}

s->dma_out->client.push = eth_tx_push;
Expand All @@ -611,7 +612,6 @@ static int fs_eth_init(SysBusDevice *sbd)

tdk_init(&s->phy);
mdio_attach(&s->mdio_bus, &s->phy, s->phyaddr);
return 0;
}

static Property etraxfs_eth_properties[] = {
Expand All @@ -625,9 +625,8 @@ static Property etraxfs_eth_properties[] = {
static void etraxfs_eth_class_init(ObjectClass *klass, void *data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
SysBusDeviceClass *k = SYS_BUS_DEVICE_CLASS(klass);

k->init = fs_eth_init;
dc->realize = etraxfs_eth_realize;
dc->props = etraxfs_eth_properties;
/* Reason: pointer properties "dma_out", "dma_in" */
dc->user_creatable = false;
Expand Down

0 comments on commit c24828b

Please sign in to comment.