Skip to content

Commit

Permalink
ivshmem, qdev-monitor: fix order of qerror parameters
Browse files Browse the repository at this point in the history
Now that the QERR_ macros no longer contain a json dictionary,
the order of some parameters needs to be fixed for them to appear
correctly.

Signed-off-by: Alberto Garcia <agarcia@igalia.com>
Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
  • Loading branch information
bertogg authored and Stefan Hajnoczi committed Aug 15, 2012
1 parent bb95586 commit c3594ed
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion hw/ivshmem.c
Expand Up @@ -677,7 +677,8 @@ static int pci_ivshmem_init(PCIDevice *dev)
}

if (s->role_val == IVSHMEM_PEER) {
error_set(&s->migration_blocker, QERR_DEVICE_FEATURE_BLOCKS_MIGRATION, "ivshmem", "peer mode");
error_set(&s->migration_blocker, QERR_DEVICE_FEATURE_BLOCKS_MIGRATION,
"peer mode", "ivshmem");
migrate_add_blocker(s->migration_blocker);
}

Expand Down
2 changes: 1 addition & 1 deletion hw/qdev-monitor.c
Expand Up @@ -443,7 +443,7 @@ DeviceState *qdev_device_add(QemuOpts *opts)
bus = qbus_find_recursive(sysbus_get_default(), NULL, k->bus_type);
if (!bus) {
qerror_report(QERR_NO_BUS_FOR_DEVICE,
driver, k->bus_type);
k->bus_type, driver);
return NULL;
}
}
Expand Down

0 comments on commit c3594ed

Please sign in to comment.