Skip to content

Commit

Permalink
s390/kvm: split kvm mem slots at 4TB
Browse files Browse the repository at this point in the history
Instead of splitting at an unaligned address, we can simply split at
4TB.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Acked-by: Igor Mammedov <imammedo@redhat.com>
  • Loading branch information
borntraeger committed Sep 30, 2019
1 parent fb1fc5a commit c5b9ce5
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions target/s390x/kvm.c
Expand Up @@ -126,12 +126,11 @@
/*
* KVM does only support memory slots up to KVM_MEM_MAX_NR_PAGES pages
* as the dirty bitmap must be managed by bitops that take an int as
* position indicator. If we have a guest beyond that we will split off
* new subregions. The split must happen on a segment boundary (1MB).
* position indicator. This would end at an unaligned address
* (0x7fffff00000). As future variants might provide larger pages
* and to make all addresses properly aligned, let us split at 4TB.
*/
#define KVM_MEM_MAX_NR_PAGES ((1ULL << 31) - 1)
#define SEG_MSK (~0xfffffULL)
#define KVM_SLOT_MAX_BYTES ((KVM_MEM_MAX_NR_PAGES * TARGET_PAGE_SIZE) & SEG_MSK)
#define KVM_SLOT_MAX_BYTES (4UL * TiB)

static CPUWatchpoint hw_watchpoint;
/*
Expand Down

0 comments on commit c5b9ce5

Please sign in to comment.