Skip to content

Commit

Permalink
mac_via: always clear ADB interrupt when switching to A/UX mode
Browse files Browse the repository at this point in the history
When the NetBSD kernel initialises it can leave the ADB interrupt asserted
depending upon where in the ADB poll cycle the MacOS ADB interrupt handler
is when the NetBSD kernel disables interrupts.

The NetBSD ADB driver uses the ADB interrupt state to determine if the ADB
is busy and refuses to send ADB commands unless it is clear. To ensure that
this doesn't happen, always clear the ADB interrupt when switching to A/UX
mode to ensure that the bus enumeration always occurs.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-ID: <20231004083806.757242-18-mark.cave-ayland@ilande.co.uk>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
  • Loading branch information
mcayland authored and vivier committed Oct 6, 2023
1 parent 7ebfb91 commit c698b0c
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions hw/misc/mac_via.c
Original file line number Diff line number Diff line change
Expand Up @@ -875,6 +875,15 @@ static void via1_auxmode_update(MOS6522Q800VIA1State *v1s)
if (irq != oldirq) {
trace_via1_auxmode(irq);
qemu_set_irq(v1s->auxmode_irq, irq);

/*
* Clear the ADB interrupt. MacOS can leave VIA1B_vADBInt asserted
* (low) if a poll sequence doesn't complete before NetBSD disables
* interrupts upon boot. Fortunately NetBSD switches to the so-called
* "A/UX" interrupt mode after it initialises, so we can use this as
* a convenient place to clear the ADB interrupt for now.
*/
s->b |= VIA1B_vADBInt;
}
}

Expand Down

0 comments on commit c698b0c

Please sign in to comment.