Skip to content

Commit

Permalink
qga: use exit() when parsing options
Browse files Browse the repository at this point in the history
The option parsing is going to be moved to a separate function,
use exit() consistently.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Denis V. Lunev <den@openvz.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
  • Loading branch information
elmarco authored and mdroth committed Sep 1, 2015
1 parent 2e2a58e commit c6c8452
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions qga/main.c
Expand Up @@ -992,14 +992,14 @@ int main(int argc, char **argv)
break;
case 'V':
printf("QEMU Guest Agent %s\n", QEMU_VERSION);
return 0;
exit(EXIT_SUCCESS);
case 'd':
daemonize = 1;
break;
case 'b': {
if (is_help_option(optarg)) {
qmp_for_each_command(ga_print_cmd, NULL);
return 0;
exit(EXIT_SUCCESS);
}
for (j = 0, i = 0, len = strlen(optarg); i < len; i++) {
if (optarg[i] == ',') {
Expand Down Expand Up @@ -1027,36 +1027,36 @@ int main(int argc, char **argv)
NULL :
state_dir;
if (ga_install_vss_provider()) {
return EXIT_FAILURE;
exit(EXIT_FAILURE);
}
if (ga_install_service(path, log_filepath, fixed_state_dir)) {
return EXIT_FAILURE;
exit(EXIT_FAILURE);
}
return 0;
exit(EXIT_SUCCESS);
} else if (strcmp(service, "uninstall") == 0) {
ga_uninstall_vss_provider();
return ga_uninstall_service();
exit(ga_uninstall_service());
} else if (strcmp(service, "vss-install") == 0) {
if (ga_install_vss_provider()) {
return EXIT_FAILURE;
exit(EXIT_FAILURE);
}
return EXIT_SUCCESS;
exit(EXIT_SUCCESS);
} else if (strcmp(service, "vss-uninstall") == 0) {
ga_uninstall_vss_provider();
return EXIT_SUCCESS;
exit(EXIT_SUCCESS);
} else {
printf("Unknown service command.\n");
return EXIT_FAILURE;
exit(EXIT_FAILURE);
}
break;
#endif
case 'h':
usage(argv[0]);
return 0;
exit(EXIT_SUCCESS);
case '?':
g_print("Unknown option, try '%s --help' for more information.\n",
argv[0]);
return EXIT_FAILURE;
exit(EXIT_FAILURE);
}
}

Expand Down

0 comments on commit c6c8452

Please sign in to comment.