Skip to content

Commit

Permalink
tests/device-plug: Add CPU core unplug request test for spapr
Browse files Browse the repository at this point in the history
We can easily test this, just like PCI. On s390x, cpu unplug is not
supported. On x86 ACPI, cpu unplug requires guest interaction to work, so
it can't be tested that easily. We might add tests for ACPI later.

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20190218092202.26683-6-david@redhat.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
  • Loading branch information
davidhildenbrand authored and dgibson committed Feb 25, 2019
1 parent 613ebbe commit c76480e
Showing 1 changed file with 20 additions and 0 deletions.
20 changes: 20 additions & 0 deletions tests/device-plug-test.c
Expand Up @@ -101,6 +101,21 @@ static void test_ccw_unplug(void)
qtest_quit(qtest);
}

static void test_spapr_cpu_unplug_request(void)
{
QTestState *qtest;

qtest = qtest_initf("-cpu power9_v2.0 -smp 1,maxcpus=2 "
"-device power9_v2.0-spapr-cpu-core,core-id=1,id=dev0");

/* similar to test_pci_unplug_request */
device_del_request(qtest, "dev0");
system_reset(qtest);
wait_device_deleted_event(qtest, "dev0");

qtest_quit(qtest);
}

int main(int argc, char **argv)
{
const char *arch = qtest_get_arch();
Expand All @@ -120,5 +135,10 @@ int main(int argc, char **argv)
test_ccw_unplug);
}

if (!strcmp(arch, "ppc64")) {
qtest_add_func("/device-plug/spapr-cpu-unplug-request",
test_spapr_cpu_unplug_request);
}

return g_test_run();
}

0 comments on commit c76480e

Please sign in to comment.