Skip to content

Commit

Permalink
memory: Remove AddressSpace pointer from AddressSpaceDispatch
Browse files Browse the repository at this point in the history
AS in ASD is only used to pass AS from mem_begin() to register_subpage()
to store it in MemoryRegionSection, we can do this directly now.

This should cause no behavioural change.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Message-Id: <20170921085110.25598-6-aik@ozlabs.ru>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
  • Loading branch information
aik authored and bonzini committed Sep 21, 2017
1 parent 66a6df1 commit c775252
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions exec.c
Expand Up @@ -193,7 +193,6 @@ struct AddressSpaceDispatch {
*/
PhysPageEntry phys_map;
PhysPageMap map;
AddressSpace *as;
};

#define SUBPAGE_IDX(addr) ((addr) & ~TARGET_PAGE_MASK)
Expand Down Expand Up @@ -1303,7 +1302,8 @@ static void phys_sections_free(PhysPageMap *map)
g_free(map->nodes);
}

static void register_subpage(AddressSpaceDispatch *d, MemoryRegionSection *section)
static void register_subpage(AddressSpace *as, AddressSpaceDispatch *d,
MemoryRegionSection *section)
{
subpage_t *subpage;
hwaddr base = section->offset_within_address_space
Expand All @@ -1318,8 +1318,8 @@ static void register_subpage(AddressSpaceDispatch *d, MemoryRegionSection *secti
assert(existing->mr->subpage || existing->mr == &io_mem_unassigned);

if (!(existing->mr->subpage)) {
subpage = subpage_init(d->as, base);
subsection.address_space = d->as;
subpage = subpage_init(as, base);
subsection.address_space = as;
subsection.mr = &subpage->iomem;
phys_page_set(d, base >> TARGET_PAGE_BITS, 1,
phys_section_add(&d->map, &subsection));
Expand Down Expand Up @@ -1356,7 +1356,7 @@ void mem_add(AddressSpace *as, FlatView *fv, MemoryRegionSection *section)
- now.offset_within_address_space;

now.size = int128_min(int128_make64(left), now.size);
register_subpage(d, &now);
register_subpage(as, d, &now);
} else {
now.size = int128_zero();
}
Expand All @@ -1366,10 +1366,10 @@ void mem_add(AddressSpace *as, FlatView *fv, MemoryRegionSection *section)
remain.offset_within_region += int128_get64(now.size);
now = remain;
if (int128_lt(remain.size, page_size)) {
register_subpage(d, &now);
register_subpage(as, d, &now);
} else if (remain.offset_within_address_space & ~TARGET_PAGE_MASK) {
now.size = page_size;
register_subpage(d, &now);
register_subpage(as, d, &now);
} else {
now.size = int128_and(now.size, int128_neg(page_size));
register_multipage(d, &now);
Expand Down Expand Up @@ -2685,7 +2685,6 @@ AddressSpaceDispatch *mem_begin(AddressSpace *as)
assert(n == PHYS_SECTION_WATCH);

d->phys_map = (PhysPageEntry) { .ptr = PHYS_MAP_NODE_NIL, .skip = 1 };
d->as = as;

return d;
}
Expand Down

0 comments on commit c775252

Please sign in to comment.