Skip to content

Commit

Permalink
block/rbd: parse all options via bdrv_parse_filename
Browse files Browse the repository at this point in the history
Get rid of qemu_rbd_parsename in favor of bdrv_parse_filename.
This simplifies a lot of the parsing as well, as we can treat everything
a bit simpler since nonexistent options are simply NULL pointers instead
of empty strings.

An important item to note:

Ceph has many extra option values that can be specified as key/value
pairs.  This was handled previously in the driver by extracting the
values that the QEMU driver cared about, and then blindly passing all
extra options to rbd after splitting them into key/value pairs, and
cleaning up any special character escaping.

The practice is continued in this patch; there is an option
"keyvalue-pairs" that is populated with all the key/value pairs that the
QEMU driver does not care about.  These key/value pairs will override
any settings in the 'conf' configuration file, just as they did before.

Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Jeff Cody <jcody@redhat.com>
  • Loading branch information
codyprime committed Feb 28, 2017
1 parent 0f9d252 commit c7cacb3
Showing 1 changed file with 151 additions and 148 deletions.

0 comments on commit c7cacb3

Please sign in to comment.