Skip to content

Commit

Permalink
vhost-user: wait until backend init is completed
Browse files Browse the repository at this point in the history
The chardev waits for an initial connection before starting qemu, and
vhost-user should wait for the backend negotiation to be completed
before starting qemu too.

vhost-user is started in the net_vhost_user_event callback, which is
synchronously called after the socket is connected. Use a
VhostUserState.started flag to indicate vhost-user init completed
successfully and qemu can be started.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
  • Loading branch information
elmarco authored and mstsirkin committed Jul 28, 2016
1 parent d7a04fd commit c89804d
Showing 1 changed file with 16 additions and 2 deletions.
18 changes: 16 additions & 2 deletions net/vhost-user.c
Expand Up @@ -24,6 +24,7 @@ typedef struct VhostUserState {
VHostNetState *vhost_net;
guint watch;
uint64_t acked_features;
bool started;
} VhostUserState;

typedef struct VhostUserChardevProps {
Expand Down Expand Up @@ -220,6 +221,7 @@ static void net_vhost_user_event(void *opaque, int event)
return;
}
qmp_set_link(name, true, &err);
s->started = true;
break;
case CHR_EVENT_CLOSED:
qmp_set_link(name, false, &err);
Expand All @@ -238,7 +240,7 @@ static int net_vhost_user_init(NetClientState *peer, const char *device,
const char *name, CharDriverState *chr,
int queues)
{
NetClientState *nc;
NetClientState *nc, *nc0 = NULL;
VhostUserState *s;
int i;

Expand All @@ -247,6 +249,9 @@ static int net_vhost_user_init(NetClientState *peer, const char *device,

for (i = 0; i < queues; i++) {
nc = qemu_new_net_client(&net_vhost_user_info, peer, device, name);
if (!nc0) {
nc0 = nc;
}

snprintf(nc->info_str, sizeof(nc->info_str), "vhost-user%d to %s",
i, chr->label);
Expand All @@ -257,7 +262,16 @@ static int net_vhost_user_init(NetClientState *peer, const char *device,
s->chr = chr;
}

qemu_chr_add_handlers(chr, NULL, NULL, net_vhost_user_event, nc[0].name);
s = DO_UPCAST(VhostUserState, nc, nc0);
do {
Error *err = NULL;
if (qemu_chr_wait_connected(chr, &err) < 0) {
error_report_err(err);
return -1;
}
qemu_chr_add_handlers(chr, NULL, NULL,
net_vhost_user_event, nc0->name);
} while (!s->started);

assert(s->vhost_net);

Expand Down

2 comments on commit c89804d

@hewenjia
Copy link

@hewenjia hewenjia commented on c89804d Feb 23, 2024 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yyjuntion
Copy link

@yyjuntion yyjuntion commented on c89804d Feb 23, 2024 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.