Skip to content

Commit

Permalink
virtio-pci: drop identical virtio_pci_cap
Browse files Browse the repository at this point in the history
Now the three struct virtio_pci_caps are identical,
lets drop two of them ;)

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
  • Loading branch information
kraxel authored and mstsirkin committed Jun 10, 2015
1 parent fc00490 commit cc52ea9
Showing 1 changed file with 5 additions and 13 deletions.
18 changes: 5 additions & 13 deletions hw/virtio/virtio-pci.c
Expand Up @@ -1341,16 +1341,8 @@ static void virtio_pci_device_plugged(DeviceState *d, Error **errp)


if (modern) {
struct virtio_pci_cap common = {
.cap_len = sizeof common,
.bar = modern_mem_bar,
};
struct virtio_pci_cap isr = {
.cap_len = sizeof isr,
.bar = modern_mem_bar,
};
struct virtio_pci_cap device = {
.cap_len = sizeof device,
struct virtio_pci_cap cap = {
.cap_len = sizeof cap,
.bar = modern_mem_bar,
};
struct virtio_pci_notify_cap notify = {
Expand All @@ -1367,9 +1359,9 @@ static void virtio_pci_device_plugged(DeviceState *d, Error **errp)
2 * QEMU_VIRTIO_PCI_QUEUE_MEM_MULT *
VIRTIO_QUEUE_MAX);
virtio_pci_modern_regions_init(proxy);
virtio_pci_modern_region_map(proxy, &proxy->common, &common);
virtio_pci_modern_region_map(proxy, &proxy->isr, &isr);
virtio_pci_modern_region_map(proxy, &proxy->device, &device);
virtio_pci_modern_region_map(proxy, &proxy->common, &cap);
virtio_pci_modern_region_map(proxy, &proxy->isr, &cap);
virtio_pci_modern_region_map(proxy, &proxy->device, &cap);
virtio_pci_modern_region_map(proxy, &proxy->notify, &notify.cap);
pci_register_bar(&proxy->pci_dev, modern_mem_bar,
PCI_BASE_ADDRESS_SPACE_MEMORY |
Expand Down

0 comments on commit cc52ea9

Please sign in to comment.