Skip to content

Commit

Permalink
target-ppc: kvm: Fix memory overflow issue about strncat()
Browse files Browse the repository at this point in the history
strncat() will append additional '\0' to destination buffer, so need
additional 1 byte for it, or may cause memory overflow, just like other
area within QEMU have done.

And can use g_strdup_printf() instead of strncat(), which may be more
easier understanding.

Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
Signed-off-by: Alexander Graf <agraf@suse.de>
  • Loading branch information
Chen-Gang authored and agraf committed Nov 4, 2014
1 parent f58aa48 commit cc64b1a
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions target-ppc/kvm.c
Expand Up @@ -1782,7 +1782,7 @@ static int kvmppc_find_cpu_dt(char *buf, int buf_len)
* format) */
static uint64_t kvmppc_read_int_cpu_dt(const char *propname)
{
char buf[PATH_MAX];
char buf[PATH_MAX], *tmp;
union {
uint32_t v32;
uint64_t v64;
Expand All @@ -1794,10 +1794,10 @@ static uint64_t kvmppc_read_int_cpu_dt(const char *propname)
return -1;
}

strncat(buf, "/", sizeof(buf) - strlen(buf));
strncat(buf, propname, sizeof(buf) - strlen(buf));
tmp = g_strdup_printf("%s/%s", buf, propname);

f = fopen(buf, "rb");
f = fopen(tmp, "rb");
g_free(tmp);
if (!f) {
return -1;
}
Expand Down

0 comments on commit cc64b1a

Please sign in to comment.