Skip to content

Commit

Permalink
hw/isa: fix ISA_SUPERIO dependencies
Browse files Browse the repository at this point in the history
ISA_SUPERIO does not provide an ISA bus, so it should not select the symbol:
instead it requires one.  Among its users, VT82C686 is the only one that
is a PCI-ISA bridge and does not already select ISA_BUS.

Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Bernhard Beschow <shentey@gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <20240213155005.109954-5-pbonzini@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
  • Loading branch information
bonzini authored and philmd committed Feb 15, 2024
1 parent e6f2193 commit cf5f5f9
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion hw/isa/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ config I82378

config ISA_SUPERIO
bool
select ISA_BUS
depends on ISA_BUS
select PCKBD
select PARALLEL
select SERIAL_ISA
Expand Down Expand Up @@ -47,6 +47,7 @@ config PIIX

config VT82C686
bool
select ISA_BUS
select ISA_SUPERIO
select ACPI
select ACPI_SMBUS
Expand Down

0 comments on commit cf5f5f9

Please sign in to comment.