Skip to content

Commit

Permalink
hw/net: e1000e: Don't zero out the VLAN tag in the legacy RX descriptor
Browse files Browse the repository at this point in the history
In the legacy RX descriptor mode, VLAN tag was saved to d->special
by e1000e_build_rx_metadata() in e1000e_write_lgcy_rx_descr(), but
it was then zeroed out again at the end of the call, which is wrong.

Fixes: c89d416 ("e1000e: Don't zero out buffer address in rx descriptor")
Reported-by: Markus Carlstedt <markus.carlstedt@windriver.com>
Signed-off-by: Christina Wang <christina.wang@windriver.com>
Signed-off-by: Bin Meng <bin.meng@windriver.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
  • Loading branch information
wangtingtina authored and jasowang committed Aug 2, 2021
1 parent d897056 commit cfe6d68
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion hw/net/e1000e_core.c
Expand Up @@ -1285,7 +1285,6 @@ e1000e_write_lgcy_rx_descr(E1000ECore *core, uint8_t *desc,
&d->special);
d->errors = (uint8_t) (le32_to_cpu(status_flags) >> 24);
d->status = (uint8_t) le32_to_cpu(status_flags);
d->special = 0;
}

static inline void
Expand Down

0 comments on commit cfe6d68

Please sign in to comment.