Skip to content

Commit

Permalink
nbd/trivial: fix type cast for ioctl
Browse files Browse the repository at this point in the history
This fixes ioctl behavior on powerpc e6500 platforms with 64bit kernel and 32bit
userspace. The current type cast has no effect there and the value passed to the
kernel is still 0. Probably an issue related to the compiler, since I'm assuming
the same configuration works on a similar setup on x86.

Also ensure consistency with previous type cast in TRACE message.

Signed-off-by: Bogdan Purcareata <bogdan.purcareata@freescale.com>
Message-Id: <1428058914-32050-1-git-send-email-bogdan.purcareata@freescale.com>
Cc: qemu-stable@nongnu.org
[Fix parens as noticed by Michael. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
  • Loading branch information
Bogdan Purcareata authored and bonzini committed Apr 28, 2015
1 parent 510a647 commit d064d9f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion nbd.c
Expand Up @@ -681,7 +681,7 @@ int nbd_init(int fd, int csock, uint32_t flags, off_t size)

TRACE("Setting size to %zd block(s)", (size_t)(size / BDRV_SECTOR_SIZE));

if (ioctl(fd, NBD_SET_SIZE_BLOCKS, size / (size_t)BDRV_SECTOR_SIZE) < 0) {
if (ioctl(fd, NBD_SET_SIZE_BLOCKS, (size_t)(size / BDRV_SECTOR_SIZE)) < 0) {
int serrno = errno;
LOG("Failed setting size (in blocks)");
return -serrno;
Expand Down

0 comments on commit d064d9f

Please sign in to comment.