Skip to content

Commit

Permalink
target-arm: Fix A64 Neon MLS
Browse files Browse the repository at this point in the history
The order of operands for the accumulate step in disas_simd_3same_int()
was reversed. This only affected the MLS instruction, since all the
other accumulating instructions in this category perform an addition
rather than a subtraction.

Reported-by: Laurent Desnogues <laurent.desnogues@gmail.com>
Tested-by: Laurent Desnogues <laurent.desnogues@gmail.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
  • Loading branch information
pm215 committed Mar 24, 2014
1 parent 3a87f8b commit d108609
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion target-arm/translate-a64.c
Expand Up @@ -8925,7 +8925,7 @@ static void disas_simd_3same_int(DisasContext *s, uint32_t insn)

genfn = fns[size][is_sub];
read_vec_element_i32(s, tcg_op1, rd, pass, MO_32);
genfn(tcg_res, tcg_res, tcg_op1);
genfn(tcg_res, tcg_op1, tcg_res);
}

write_vec_element_i32(s, tcg_res, rd, pass, MO_32);
Expand Down

0 comments on commit d108609

Please sign in to comment.