Skip to content

Commit

Permalink
python: add pylint import exceptions
Browse files Browse the repository at this point in the history
Pylint 2.5.x - 2.7.x have regressions that make import checking
inconsistent, see:

pylint-dev/pylint#3609
pylint-dev/pylint#3624
pylint-dev/pylint#3651

Pinning to 2.4.4 is worse, because it mandates versions of shared
dependencies that are too old for features we want in isort and mypy.
Oh well.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Message-id: 20210527211715.394144-16-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
  • Loading branch information
jnsnow committed Jun 1, 2021
1 parent 41c1d81 commit d1e0476
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions python/qemu/machine/__init__.py
Expand Up @@ -22,6 +22,9 @@
# the COPYING file in the top-level directory.
#

# pylint: disable=import-error
# see: https://github.com/PyCQA/pylint/issues/3624
# see: https://github.com/PyCQA/pylint/issues/3651
from .machine import QEMUMachine
from .qtest import QEMUQtestMachine, QEMUQtestProtocol

Expand Down
2 changes: 1 addition & 1 deletion python/qemu/machine/machine.py
Expand Up @@ -38,7 +38,7 @@
Type,
)

from qemu.qmp import (
from qemu.qmp import ( # pylint: disable=import-error
QEMUMonitorProtocol,
QMPMessage,
QMPReturnValue,
Expand Down
2 changes: 1 addition & 1 deletion python/qemu/machine/qtest.py
Expand Up @@ -26,7 +26,7 @@
TextIO,
)

from qemu.qmp import SocketAddrT
from qemu.qmp import SocketAddrT # pylint: disable=import-error

from .machine import QEMUMachine

Expand Down

0 comments on commit d1e0476

Please sign in to comment.