Skip to content

Commit

Permalink
tests: Check serial output of firmware boot of some machines
Browse files Browse the repository at this point in the history
Some of the machines that we have got a firmware image for write
some output to the serial console while booting up. We can use
this output to make sure that the machine is basically working,
so this adds a test that checks the output of these machines
for some well-known "magic" strings.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
  • Loading branch information
huth authored and dgibson committed Sep 7, 2016
1 parent 2953154 commit d2ab58f
Show file tree
Hide file tree
Showing 2 changed files with 118 additions and 0 deletions.
8 changes: 8 additions & 0 deletions tests/Makefile.include
Expand Up @@ -195,6 +195,7 @@ check-qtest-i386-y += tests/hd-geo-test$(EXESUF)
gcov-files-i386-y += hw/block/hd-geometry.c
check-qtest-i386-y += tests/boot-order-test$(EXESUF)
check-qtest-i386-y += tests/bios-tables-test$(EXESUF)
check-qtest-i386-y += tests/boot-serial-test$(EXESUF)
check-qtest-i386-y += tests/pxe-test$(EXESUF)
check-qtest-i386-y += tests/rtc-test$(EXESUF)
check-qtest-i386-y += tests/ipmi-kcs-test$(EXESUF)
Expand Down Expand Up @@ -242,6 +243,8 @@ check-qtest-x86_64-y += $(check-qtest-i386-y)
gcov-files-i386-y += i386-softmmu/hw/timer/mc146818rtc.c
gcov-files-x86_64-y = $(subst i386-softmmu/,x86_64-softmmu/,$(gcov-files-i386-y))

check-qtest-alpha-y = tests/boot-serial-test$(EXESUF)

check-qtest-mips-y = tests/endianness-test$(EXESUF)

check-qtest-mips64-y = tests/endianness-test$(EXESUF)
Expand All @@ -252,6 +255,7 @@ check-qtest-ppc-y = tests/endianness-test$(EXESUF)
check-qtest-ppc-y += tests/boot-order-test$(EXESUF)
check-qtest-ppc-y += tests/prom-env-test$(EXESUF)
check-qtest-ppc-y += tests/drive_del-test$(EXESUF)
check-qtest-ppc-y += tests/boot-serial-test$(EXESUF)

check-qtest-ppc64-y = tests/spapr-phb-test$(EXESUF)
gcov-files-ppc64-y = ppc64-softmmu/hw/ppc/spapr_pci.c
Expand All @@ -260,6 +264,7 @@ check-qtest-ppc64-y += tests/boot-order-test$(EXESUF)
check-qtest-ppc64-y += tests/prom-env-test$(EXESUF)
check-qtest-ppc64-y += tests/drive_del-test$(EXESUF)
check-qtest-ppc64-y += tests/postcopy-test$(EXESUF)
check-qtest-ppc64-y += tests/boot-serial-test$(EXESUF)

check-qtest-sh4-y = tests/endianness-test$(EXESUF)

Expand All @@ -285,6 +290,8 @@ check-qtest-microblazeel-y = $(check-qtest-microblaze-y)

check-qtest-xtensaeb-y = $(check-qtest-xtensa-y)

check-qtest-s390x-y = tests/boot-serial-test$(EXESUF)

check-qtest-generic-y += tests/qom-test$(EXESUF)

qapi-schema += alternate-any.json
Expand Down Expand Up @@ -590,6 +597,7 @@ tests/ipmi-kcs-test$(EXESUF): tests/ipmi-kcs-test.o
tests/ipmi-bt-test$(EXESUF): tests/ipmi-bt-test.o
tests/hd-geo-test$(EXESUF): tests/hd-geo-test.o
tests/boot-order-test$(EXESUF): tests/boot-order-test.o $(libqos-obj-y)
tests/boot-serial-test$(EXESUF): tests/boot-serial-test.o $(libqos-obj-y)
tests/bios-tables-test$(EXESUF): tests/bios-tables-test.o \
tests/boot-sector.o $(libqos-obj-y)
tests/pxe-test$(EXESUF): tests/pxe-test.o tests/boot-sector.o $(libqos-obj-y)
Expand Down
110 changes: 110 additions & 0 deletions tests/boot-serial-test.c
@@ -0,0 +1,110 @@
/*
* Test serial output of some machines.
*
* Copyright 2016 Thomas Huth, Red Hat Inc.
*
* This work is licensed under the terms of the GNU GPL, version 2
* or later. See the COPYING file in the top-level directory.
*
* This test is used to check that the serial output of the firmware
* (that we provide for some machines) contains an expected string.
* Thus we check that the firmware still boots at least to a certain
* point and so we know that the machine is not completely broken.
*/

#include "qemu/osdep.h"
#include "libqtest.h"

typedef struct testdef {
const char *arch; /* Target architecture */
const char *machine; /* Name of the machine */
const char *extra; /* Additional parameters */
const char *expect; /* Expected string in the serial output */
} testdef_t;

static testdef_t tests[] = {
{ "alpha", "clipper", "", "PCI:" },
{ "ppc", "ppce500", "", "U-Boot" },
{ "ppc", "prep", "", "Open Hack'Ware BIOS" },
{ "ppc64", "ppce500", "", "U-Boot" },
{ "ppc64", "prep", "", "Open Hack'Ware BIOS" },
{ "ppc64", "pseries", "", "Open Firmware" },
{ "i386", "isapc", "-cpu qemu32 -device sga", "SGABIOS" },
{ "i386", "pc", "-device sga", "SGABIOS" },
{ "i386", "q35", "-device sga", "SGABIOS" },
{ "x86_64", "isapc", "-cpu qemu32 -device sga", "SGABIOS" },
{ "x86_64", "q35", "-device sga", "SGABIOS" },
{ "s390x", "s390-ccw-virtio",
"-nodefaults -device sclpconsole,chardev=serial0", "virtio device" },
{ NULL }
};

static void check_guest_output(const testdef_t *test, int fd)
{
bool output_ok = false;
int i, nbr, pos = 0;
char ch;

/* Poll serial output... Wait at most 60 seconds */
for (i = 0; i < 6000; ++i) {
while ((nbr = read(fd, &ch, 1)) == 1) {
if (ch == test->expect[pos]) {
pos += 1;
if (test->expect[pos] == '\0') {
/* We've reached the end of the expected string! */
output_ok = true;
goto done;
}
} else {
pos = 0;
}
}
g_assert(nbr >= 0);
g_usleep(10000);
}

done:
g_assert(output_ok);
}

static void test_machine(const void *data)
{
const testdef_t *test = data;
char *args;
char tmpname[] = "/tmp/qtest-boot-serial-XXXXXX";
int fd;

fd = mkstemp(tmpname);
g_assert(fd != -1);

args = g_strdup_printf("-M %s,accel=tcg -chardev file,id=serial0,path=%s"
" -serial chardev:serial0 %s", test->machine,
tmpname, test->extra);

qtest_start(args);
unlink(tmpname);

check_guest_output(test, fd);
qtest_quit(global_qtest);

g_free(args);
close(fd);
}

int main(int argc, char *argv[])
{
const char *arch = qtest_get_arch();
int i;

g_test_init(&argc, &argv, NULL);

for (i = 0; tests[i].arch != NULL; i++) {
if (strcmp(arch, tests[i].arch) == 0) {
char *name = g_strdup_printf("boot-serial/%s", tests[i].machine);
qtest_add_data_func(name, &tests[i], test_machine);
g_free(name);
}
}

return g_test_run();
}

0 comments on commit d2ab58f

Please sign in to comment.