Skip to content

Commit

Permalink
hw/i386/acpi_build.c: Avoid shifting left into sign bit
Browse files Browse the repository at this point in the history
Add U suffix to avoid undefined behaviour.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
  • Loading branch information
pm215 authored and Michael Tokarev committed Mar 27, 2014
1 parent ac43fa5 commit d9631b9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hw/i386/acpi-build.c
Expand Up @@ -907,7 +907,7 @@ static void build_pci_bus_end(PCIBus *bus, void *bus_state)

build_append_byte(notify, 0x7B); /* AndOp */
build_append_byte(notify, 0x68); /* Arg0Op */
build_append_int(notify, 0x1 << i);
build_append_int(notify, 0x1U << i);
build_append_byte(notify, 0x00); /* NullName */
build_append_byte(notify, 0x86); /* NotifyOp */
build_append_nameseg(notify, "S%.02X_", PCI_DEVFN(i, 0));
Expand Down

0 comments on commit d9631b9

Please sign in to comment.