Skip to content

Commit

Permalink
vl: Parse legacy default_machine_opts
Browse files Browse the repository at this point in the history
qemu can't start a xen vm after commit d8fb7d0
"vl: switch -M parsing to keyval" with:

$ ./qemu-system-i386 -M xenfv
Unexpected error in object_property_find_err() at ../qom/object.c:1298:
qemu-system-i386: Property 'xenfv-3.1-machine.accel' not found
Aborted (core dumped)

The default_machine_opts handling doesn't process the legacy machine
options like "accel".  Call qemu_apply_legacy_machine_options to provide
the legacy handling.

Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
Message-Id: <20210713021552.19110-1-jandryuk@gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
  • Loading branch information
jandryuk authored and bonzini committed Jul 20, 2021
1 parent 461fea9 commit dadafe6
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions softmmu/vl.c
Expand Up @@ -2126,6 +2126,7 @@ static void qemu_create_machine(QDict *qdict)
QDict *default_opts =
keyval_parse(machine_class->default_machine_opts, NULL, NULL,
&error_abort);
qemu_apply_legacy_machine_options(default_opts);
object_set_properties_from_keyval(OBJECT(current_machine), default_opts,
false, &error_abort);
qobject_unref(default_opts);
Expand Down

0 comments on commit dadafe6

Please sign in to comment.