Skip to content

Commit

Permalink
hw/audio/ac97: Remove unimplemented reset functions
Browse files Browse the repository at this point in the history
The warm_reset() and cold_reset() functions are not implemented and do
nothing so no point in calling them or keep around as dead code.
Therefore remove them for now.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Víctor Colombo <victor.colombo@eldorado.org.br>
Message-Id: <cc6e99fd498a9ae358ebce787fc04ab6e8201879.1650706617.git.balaton@eik.bme.hu>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
  • Loading branch information
zbalaton authored and bonzini committed May 25, 2022
1 parent ab9f0f7 commit dafea9e
Showing 1 changed file with 1 addition and 16 deletions.
17 changes: 1 addition & 16 deletions hw/audio/ac97.c
Expand Up @@ -222,16 +222,6 @@ static void po_callback(void *opaque, int free);
static void pi_callback(void *opaque, int avail);
static void mc_callback(void *opaque, int avail);

static void warm_reset(AC97LinkState *s)
{
(void)s;
}

static void cold_reset(AC97LinkState *s)
{
(void)s;
}

static void fetch_bd(AC97LinkState *s, AC97BusMasterRegs *r)
{
uint8_t b[8];
Expand Down Expand Up @@ -921,12 +911,7 @@ static void nabm_writel(void *opaque, uint32_t addr, uint32_t val)
dolog("BDBAR[%d] <- 0x%x (bdbar 0x%x)\n", GET_BM(index), val, r->bdbar);
break;
case GLOB_CNT:
if (val & GC_WR) {
warm_reset(s);
}
if (val & GC_CR) {
cold_reset(s);
}
/* TODO: Handle WR or CR being set (warm/cold reset requests) */
if (!(val & (GC_WR | GC_CR))) {
s->glob_cnt = val & GC_VALID_MASK;
}
Expand Down

0 comments on commit dafea9e

Please sign in to comment.