Skip to content

Commit

Permalink
tests/qemu-iotests/testrunner: Quote "case not run" lines in TAP mode
Browse files Browse the repository at this point in the history
In TAP mode, the stdout is reserved for the TAP protocol, so we
have to make sure to mark other lines with a comment '#' character
at the beginning to avoid that the TAP parser at the other end
gets confused.

To test this condition, run "configure" for example with:

 --block-drv-rw-whitelist=copy-before-write,qcow2,raw,file,host_device,blkdebug,null-co,copy-on-read

so that iotest 041 will report that some tests are not run due to
the missing "quorum" driver. Without this change, "make check-block"
fails since the meson tap parser gets confused by these messages.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20220223124353.3273898-1-thuth@redhat.com>
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
  • Loading branch information
huth authored and XanClic committed Mar 7, 2022
1 parent 024354e commit db4b213
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion tests/qemu-iotests/testrunner.py
Expand Up @@ -365,7 +365,10 @@ def run_test(self, test: str,
description=res.description)

if res.casenotrun:
print(res.casenotrun)
if self.tap:
print('#' + res.casenotrun.replace('\n', '\n#'))
else:
print(res.casenotrun)

return res

Expand Down

0 comments on commit db4b213

Please sign in to comment.