Skip to content

Commit

Permalink
hw/arm/virt: fix cpu object reference leak
Browse files Browse the repository at this point in the history
object_new(FOO) returns an object with ref_cnt == 1
and following
  object_property_set_bool(cpuobj, true, "realized", NULL)
set parent of cpuobj to '/machine/unattached' which makes
ref_cnt == 2.

Since machvirt_init() doesn't take ownership of cpuobj
returned by object_new() it should explicitly drop
reference to cpuobj when dangling pointer is about to
go out of scope like it's done pc_new_cpu() to avoid
object leak.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Message-id: 1487253461-269218-1-git-send-email-imammedo@redhat.com
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
  • Loading branch information
Igor Mammedov authored and pm215 committed Feb 28, 2017
1 parent 241999b commit dbb7475
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions hw/arm/virt.c
Expand Up @@ -1378,6 +1378,7 @@ static void machvirt_init(MachineState *machine)
}

object_property_set_bool(cpuobj, true, "realized", NULL);
object_unref(cpuobj);
}
fdt_add_timer_nodes(vms);
fdt_add_cpu_nodes(vms);
Expand Down

0 comments on commit dbb7475

Please sign in to comment.