Skip to content

Commit

Permalink
tests/prom-env: Make test independent of global_qtest
Browse files Browse the repository at this point in the history
global_qtest is only needed here for one readl(). Let's replace it
with qtest_readl() and we can remove the global_qtest variable here.

Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
  • Loading branch information
huth committed Dec 17, 2018
1 parent ed398a1 commit dc4c158
Showing 1 changed file with 8 additions and 9 deletions.
17 changes: 8 additions & 9 deletions tests/prom-env-test.c
Expand Up @@ -25,14 +25,14 @@
#define MAGIC 0xcafec0de
#define ADDRESS 0x4000

static void check_guest_memory(void)
static void check_guest_memory(QTestState *qts)
{
uint32_t signature;
int i;

/* Poll until code has run and modified memory. Wait at most 600 seconds */
for (i = 0; i < 60000; ++i) {
signature = readl(ADDRESS);
signature = qtest_readl(qts, ADDRESS);
if (signature == MAGIC) {
break;
}
Expand All @@ -45,17 +45,16 @@ static void check_guest_memory(void)
static void test_machine(const void *machine)
{
const char *extra_args;
QTestState *qts;

/* The pseries firmware boots much faster without the default devices */
extra_args = strcmp(machine, "pseries") == 0 ? "-nodefaults" : "";

global_qtest = qtest_initf("-M %s,accel=tcg %s "
"-prom-env 'use-nvramrc?=true' "
"-prom-env 'nvramrc=%x %x l!' ",
(const char *)machine, extra_args,
MAGIC, ADDRESS);
check_guest_memory();
qtest_quit(global_qtest);
qts = qtest_initf("-M %s,accel=tcg %s -prom-env 'use-nvramrc?=true' "
"-prom-env 'nvramrc=%x %x l!' ", (const char *)machine,
extra_args, MAGIC, ADDRESS);
check_guest_memory(qts);
qtest_quit(qts);
}

static void add_tests(const char *machines[])
Expand Down

0 comments on commit dc4c158

Please sign in to comment.