Skip to content

Commit

Permalink
qtest/virtio-9p-test.c: remove g_test_slow() gate
Browse files Browse the repository at this point in the history
Commit 558f5c4 gated the local tests with g_test_slow() to skip them
in 'make check'. The reported issue back then was this following CI
problem:

https://lists.nongnu.org/archive/html/qemu-devel/2020-11/msg05510.html

This problem ended up being fixed after it was detected with the
recently added risc-v machine nodes [1]. virtio-9p-test.c is now
creating and removing temporary dirs for each test run, instead of
creating a single dir for the entire qos-test scope.

We're now able to run these tests with 'make check' in the CI, so let's
go ahead and re-enable them.

This reverts commit 558f5c4.

[1] https://mail.gnu.org/archive/html/qemu-devel/2024-03/msg05807.html

Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Message-Id: <20240327142011.805728-3-dbarboza@ventanamicro.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Tested-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
  • Loading branch information
danielhb authored and cschoenebeck committed Mar 28, 2024
1 parent 981eb10 commit dcae75f
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions tests/qtest/virtio-9p-test.c
Original file line number Diff line number Diff line change
Expand Up @@ -746,15 +746,6 @@ static void register_virtio_9p_test(void)


/* 9pfs test cases using the 'local' filesystem driver */

/*
* XXX: Until we are sure that these tests can run everywhere,
* keep them as "slow" so that they aren't run with "make check".
*/
if (!g_test_slow()) {
return;
}

opts.before = assign_9p_local_driver;
qos_add_test("local/config", "virtio-9p", pci_config, &opts);
qos_add_test("local/create_dir", "virtio-9p", fs_create_dir, &opts);
Expand Down

0 comments on commit dcae75f

Please sign in to comment.