Skip to content

Commit

Permalink
qcow2: update_refcount(): Reset old_table_index after qcow2_cache_put()
Browse files Browse the repository at this point in the history
In the case that update_refcount() frees a refcount block, it evicts it
from the metadata cache. Before doing so, however, it returns the
currently used refcount block to the cache because it might be the same.
Returning the refcount block early means that we need to reset
old_table_index so that we reload the refcount block in the next
iteration if it is actually still in use.

Fixes: f71c08e
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20200211094900.17315-2-kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
  • Loading branch information
kevmw committed Feb 18, 2020
1 parent 8475ea4 commit dea9052
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions block/qcow2-refcount.c
Expand Up @@ -889,6 +889,7 @@ static int QEMU_WARN_UNUSED_RESULT update_refcount(BlockDriverState *bs,
offset);
if (table != NULL) {
qcow2_cache_put(s->refcount_block_cache, &refcount_block);
old_table_index = -1;
qcow2_cache_discard(s->refcount_block_cache, table);
}

Expand Down

0 comments on commit dea9052

Please sign in to comment.