Skip to content

Commit

Permalink
ati-vga: Add some register definitions for debugging
Browse files Browse the repository at this point in the history
Add names for AMCGPIO regs to make it easier to identify these in
trace output. This is where rage128p has the DDC from the DVI port
among others but because we don't implement the flat panel controller
we don't want to connect an EDID here to make sure drivers use the VGA
output instead. But since these are often probed by drivers it helps
to see what happens by logging these registers by name.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Message-id: 31ff69ca6959d090869907774faa1af7d2c02b2b.1565558093.git.balaton@eik.bme.hu
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
  • Loading branch information
zbalaton authored and kraxel committed Aug 21, 2019
1 parent 1d8d4d8 commit df1e4cf
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
4 changes: 4 additions & 0 deletions hw/display/ati_dbg.c
Expand Up @@ -23,6 +23,10 @@ static struct ati_regdesc ati_reg_names[] = {
{"GPIO_DVI_DDC", 0x0064},
{"GPIO_MONID", 0x0068},
{"I2C_CNTL_1", 0x0094},
{"AMCGPIO_MASK_MIR", 0x009c},
{"AMCGPIO_A_MIR", 0x00a0},
{"AMCGPIO_Y_MIR", 0x00a4},
{"AMCGPIO_EN_MIR", 0x00a8},
{"PALETTE_INDEX", 0x00b0},
{"PALETTE_DATA", 0x00b4},
{"CNFG_CNTL", 0x00e0},
Expand Down
4 changes: 4 additions & 0 deletions hw/display/ati_regs.h
Expand Up @@ -41,6 +41,10 @@
#define GPIO_DVI_DDC 0x0064
#define GPIO_MONID 0x0068
#define I2C_CNTL_1 0x0094
#define AMCGPIO_MASK_MIR 0x009c
#define AMCGPIO_A_MIR 0x00a0
#define AMCGPIO_Y_MIR 0x00a4
#define AMCGPIO_EN_MIR 0x00a8
#define PALETTE_INDEX 0x00b0
#define PALETTE_DATA 0x00b4
#define CNFG_CNTL 0x00e0
Expand Down

0 comments on commit df1e4cf

Please sign in to comment.