Skip to content

Commit

Permalink
migration: add remaining params->has_* = true in migration_instance_i…
Browse files Browse the repository at this point in the history
…nit()

Some of params->has_* = true are missing in migration_instance_init, this
causes migrate_params_check() to skip some tests, allowing some
unsupported scenarios.

Fix this by adding all missing params->has_* = true in
migration_instance_init().

Fixes: 69ef1f3 ("migration: define 'tls-creds' and 'tls-hostname' migration parameters")
Fixes: 1d58872 ("migration: do not wait for free thread")
Fixes: d2f1d29 ("migration: add support for a "tls-authz" migration parameter")
Signed-off-by: Leonardo Bras <leobras@redhat.com>
Message-Id: <20220726010235.342927-1-leobras@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
  • Loading branch information
Leonardo Bras authored and dagrh committed Aug 2, 2022
1 parent 0399521 commit df67aa3
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions migration/migration.c
Expand Up @@ -4451,6 +4451,7 @@ static void migration_instance_init(Object *obj)
/* Set has_* up only for parameter checks */
params->has_compress_level = true;
params->has_compress_threads = true;
params->has_compress_wait_thread = true;
params->has_decompress_threads = true;
params->has_throttle_trigger_threshold = true;
params->has_cpu_throttle_initial = true;
Expand All @@ -4471,6 +4472,9 @@ static void migration_instance_init(Object *obj)
params->has_announce_max = true;
params->has_announce_rounds = true;
params->has_announce_step = true;
params->has_tls_creds = true;
params->has_tls_hostname = true;
params->has_tls_authz = true;

qemu_sem_init(&ms->postcopy_pause_sem, 0);
qemu_sem_init(&ms->postcopy_pause_rp_sem, 0);
Expand Down

0 comments on commit df67aa3

Please sign in to comment.