Skip to content

Commit

Permalink
util/guest-random: Fix size arg to tail memcpy
Browse files Browse the repository at this point in the history
We know that in the body of this if statement i is less than len, so
we really should be copying len - i bytes not i - len bytes.

Fix this typo.

Fixes: 8d8404f ("util: Add qemu_guest_getrandom and associated routines")
Signed-off-by: Mark Nelson <mdnelson8@gmail.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210709120600.11080-1-mdnelson8@gmail.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
  • Loading branch information
mdnelson8 authored and vivier committed Jul 9, 2021
1 parent 179a808 commit e28ffe9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion util/guest-random.c
Expand Up @@ -38,7 +38,7 @@ static int glib_random_bytes(void *buf, size_t len)
}
if (i < len) {
x = g_rand_int(rand);
__builtin_memcpy(buf + i, &x, i - len);
__builtin_memcpy(buf + i, &x, len - i);
}
return 0;
}
Expand Down

0 comments on commit e28ffe9

Please sign in to comment.