Skip to content

Commit

Permalink
migration/savevm: move non SaveStateEntry condition check out of iter…
Browse files Browse the repository at this point in the history
…ation

in_postcopy and iterable_only are not SaveStateEntry specific, it would
be more proper to check them out of iteration.

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Message-Id: <20190709140924.13291-4-richardw.yang@linux.intel.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
  • Loading branch information
Wei Yang authored and dagrh committed Aug 14, 2019
1 parent 622a80c commit e326767
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions migration/savevm.c
Expand Up @@ -1247,8 +1247,7 @@ void qemu_savevm_state_complete_postcopy(QEMUFile *f)
}

static
int qemu_savevm_state_complete_precopy_iterable(QEMUFile *f, bool in_postcopy,
bool iterable_only)
int qemu_savevm_state_complete_precopy_iterable(QEMUFile *f, bool in_postcopy)
{
SaveStateEntry *se;
int ret;
Expand All @@ -1257,7 +1256,6 @@ int qemu_savevm_state_complete_precopy_iterable(QEMUFile *f, bool in_postcopy,
if (!se->ops ||
(in_postcopy && se->ops->has_postcopy &&
se->ops->has_postcopy(se->opaque)) ||
(in_postcopy && !iterable_only) ||
!se->ops->save_live_complete_precopy) {
continue;
}
Expand Down Expand Up @@ -1369,10 +1367,11 @@ int qemu_savevm_state_complete_precopy(QEMUFile *f, bool iterable_only,

cpu_synchronize_all_states();

ret = qemu_savevm_state_complete_precopy_iterable(f, in_postcopy,
iterable_only);
if (ret) {
return ret;
if (!in_postcopy || iterable_only) {
ret = qemu_savevm_state_complete_precopy_iterable(f, in_postcopy);
if (ret) {
return ret;
}
}

if (iterable_only) {
Expand Down

0 comments on commit e326767

Please sign in to comment.