Skip to content

Commit

Permalink
numa: Move NUMA declarations from sysemu.h to numa.h
Browse files Browse the repository at this point in the history
Not all sysemu.h users need the NUMA declarations, and keeping them in a
separate file makes it easier to see what are the interfaces provided by
numa.c.

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
  • Loading branch information
ehabkost committed Feb 23, 2015
1 parent cd2d554 commit e35704b
Show file tree
Hide file tree
Showing 8 changed files with 34 additions and 19 deletions.
1 change: 1 addition & 0 deletions hw/i386/pc.c
Expand Up @@ -41,6 +41,7 @@
#include "hw/pci/msi.h"
#include "hw/sysbus.h"
#include "sysemu/sysemu.h"
#include "sysemu/numa.h"
#include "sysemu/kvm.h"
#include "kvm_i386.h"
#include "hw/xen/xen.h"
Expand Down
1 change: 1 addition & 0 deletions hw/mem/pc-dimm.c
Expand Up @@ -22,6 +22,7 @@
#include "qemu/config-file.h"
#include "qapi/visitor.h"
#include "qemu/range.h"
#include "sysemu/numa.h"

typedef struct pc_dimms_capacity {
uint64_t size;
Expand Down
1 change: 1 addition & 0 deletions hw/ppc/spapr.c
Expand Up @@ -25,6 +25,7 @@
*
*/
#include "sysemu/sysemu.h"
#include "sysemu/numa.h"
#include "hw/hw.h"
#include "hw/fw-path-provider.h"
#include "elf.h"
Expand Down
28 changes: 28 additions & 0 deletions include/sysemu/numa.h
@@ -0,0 +1,28 @@
#ifndef SYSEMU_NUMA_H
#define SYSEMU_NUMA_H

#include <stdint.h>
#include "qemu/bitmap.h"
#include "qemu/option.h"
#include "sysemu/sysemu.h"
#include "sysemu/hostmem.h"

extern int nb_numa_nodes; /* Number of NUMA nodes */
extern int max_numa_nodeid; /* Highest specified NUMA node ID, plus one.
* For all nodes, nodeid < max_numa_nodeid
*/

typedef struct node_info {
uint64_t node_mem;
DECLARE_BITMAP(node_cpu, MAX_CPUMASK_BITS);
struct HostMemoryBackend *node_memdev;
bool present;
} NodeInfo;
extern NodeInfo numa_info[MAX_NODES];
void set_numa_nodes(void);
void set_numa_modes(void);
void query_numa_node_mem(uint64_t node_mem[]);
extern QemuOptsList qemu_numa_opts;
int numa_init_func(QemuOpts *opts, void *opaque);

#endif
18 changes: 0 additions & 18 deletions include/sysemu/sysemu.h
Expand Up @@ -147,24 +147,6 @@ extern int mem_prealloc;
*/
#define MAX_CPUMASK_BITS 255

extern int nb_numa_nodes; /* Number of NUMA nodes */
extern int max_numa_nodeid; /* Highest specified NUMA node ID, plus one.
* For all nodes, nodeid < max_numa_nodeid
*/

typedef struct node_info {
uint64_t node_mem;
DECLARE_BITMAP(node_cpu, MAX_CPUMASK_BITS);
struct HostMemoryBackend *node_memdev;
bool present;
} NodeInfo;
extern NodeInfo numa_info[MAX_NODES];
void set_numa_nodes(void);
void set_numa_modes(void);
void query_numa_node_mem(uint64_t node_mem[]);
extern QemuOptsList qemu_numa_opts;
int numa_init_func(QemuOpts *opts, void *opaque);

#define MAX_OPTION_ROMS 16
typedef struct QEMUOptionRom {
const char *name;
Expand Down
1 change: 1 addition & 0 deletions monitor.c
Expand Up @@ -35,6 +35,7 @@
#include "sysemu/char.h"
#include "ui/qemu-spice.h"
#include "sysemu/sysemu.h"
#include "sysemu/numa.h"
#include "monitor/monitor.h"
#include "qemu/readline.h"
#include "ui/console.h"
Expand Down
2 changes: 1 addition & 1 deletion numa.c
Expand Up @@ -22,7 +22,7 @@
* THE SOFTWARE.
*/

#include "sysemu/sysemu.h"
#include "sysemu/numa.h"
#include "exec/cpu-common.h"
#include "qemu/bitmap.h"
#include "qom/cpu.h"
Expand Down
1 change: 1 addition & 0 deletions vl.c
Expand Up @@ -78,6 +78,7 @@ int main(int argc, char **argv)
#include "monitor/monitor.h"
#include "ui/console.h"
#include "sysemu/sysemu.h"
#include "sysemu/numa.h"
#include "exec/gdbstub.h"
#include "qemu/timer.h"
#include "sysemu/char.h"
Expand Down

0 comments on commit e35704b

Please sign in to comment.