Skip to content

Commit

Permalink
ioport: split deletion and destruction
Browse files Browse the repository at this point in the history
Of the two functions portio_list_del and portio_list_destroy,
the latter is just freeing a memory area.  However, portio_list_del
is the logical equivalent of memory_region_del_subregion so
destruction of memory regions does not belong there.

Actually, neither of these APIs are in use; portio is mostly used by
ISA devices or VGAs, and neither of these is currently hot-unpluggable.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
  • Loading branch information
bonzini committed Aug 17, 2014
1 parent eed7930 commit e3fb0ad
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions ioport.c
Expand Up @@ -149,6 +149,14 @@ void portio_list_set_flush_coalesced(PortioList *piolist)

void portio_list_destroy(PortioList *piolist)
{
MemoryRegionPortioList *mrpio;
unsigned i;

for (i = 0; i < piolist->nr; ++i) {
mrpio = container_of(piolist->regions[i], MemoryRegionPortioList, mr);
memory_region_destroy(&mrpio->mr);
g_free(mrpio);
}
g_free(piolist->regions);
}

Expand Down Expand Up @@ -291,8 +299,5 @@ void portio_list_del(PortioList *piolist)
for (i = 0; i < piolist->nr; ++i) {
mrpio = container_of(piolist->regions[i], MemoryRegionPortioList, mr);
memory_region_del_subregion(piolist->address_space, &mrpio->mr);
memory_region_destroy(&mrpio->mr);
g_free(mrpio);
piolist->regions[i] = NULL;
}
}

0 comments on commit e3fb0ad

Please sign in to comment.