Skip to content

Commit

Permalink
aspeed/i3c: Rename variable shadowing a local
Browse files Browse the repository at this point in the history
to fix warning :

  ../hw/i3c/aspeed_i3c.c: In function ‘aspeed_i3c_realize’:
  ../hw/i3c/aspeed_i3c.c:1959:17: warning: declaration of ‘dev’ shadows a parameter [-Wshadow=local]
   1959 |         Object *dev = OBJECT(&s->devices[i]);
        |                 ^~~
  ../hw/i3c/aspeed_i3c.c:1942:45: note: shadowed declaration is here
   1942 | static void aspeed_i3c_realize(DeviceState *dev, Error **errp)
        |                                ~~~~~~~~~~~~~^~~

Signed-off-by: Cédric Le Goater <clg@kaod.org>
Message-ID: <20230922155924.1172019-4-clg@kaod.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
  • Loading branch information
legoater authored and Markus Armbruster committed Sep 29, 2023
1 parent e8874c0 commit e407513
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions hw/misc/aspeed_i3c.c
Original file line number Diff line number Diff line change
Expand Up @@ -296,13 +296,13 @@ static void aspeed_i3c_realize(DeviceState *dev, Error **errp)
memory_region_add_subregion(&s->iomem_container, 0x0, &s->iomem);

for (i = 0; i < ASPEED_I3C_NR_DEVICES; ++i) {
Object *dev = OBJECT(&s->devices[i]);
Object *i3c_dev = OBJECT(&s->devices[i]);

if (!object_property_set_uint(dev, "device-id", i, errp)) {
if (!object_property_set_uint(i3c_dev, "device-id", i, errp)) {
return;
}

if (!sysbus_realize(SYS_BUS_DEVICE(dev), errp)) {
if (!sysbus_realize(SYS_BUS_DEVICE(i3c_dev), errp)) {
return;
}

Expand Down

0 comments on commit e407513

Please sign in to comment.